Support graceful shutdown #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emakeev
reviewed
Feb 25, 2021
diam/server.go
Outdated
| @@ -137,6 +142,45 @@ func (c *conn) notifyClientGone() { | |||
| } | |||
| } | |||
|
|
|||
| // A ConnState represents the state of a client connection to a server. | |||
| type ConnState int | |||
There was a problem hiding this comment.
taken from https://github.com/golang/go/blob/master/src/net/http/server.go#L2823
looks like it can be an int8 afaict, can update
emakeev
reviewed
Feb 25, 2021
diam/server.go
Outdated
| } | ||
|
|
||
| func (c ConnState) String() string { | ||
| return stateName[c] |
There was a problem hiding this comment.
name, ok := stateName[c]
if !ok {
return "UNDEFINED"
}
return name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the minimal set of logic necessary to support graceful shutdown via a
Shutdown()method from the std net/http serverNote: this does not implement the diameter peer disconnect